Skip to content

fix(deps): pin dependency versions in Cargo.toml - #534

Merged
alejandro-vaz merged 1 commit into
servo:v2from
Dazzanova:specify-version-number
Aug 31, 2026
Merged

fix(deps): pin dependency versions in Cargo.toml#534
alejandro-vaz merged 1 commit into
servo:v2from
Dazzanova:specify-version-number

Conversation

@Dazzanova

Copy link
Copy Markdown
Contributor

Summary

  • Pin all dependency versions in Cargo.toml to their exact versions from Cargo.lock.

Problem

  • Cargo.toml uses loose dependency versions, which can allow automatic patch updates and cause unexpected issues.

Solution

  • Updated all dependencies to use exact =x.y.z versions matching Cargo.lock.

Related

Closes #532

@alejandro-vaz

Copy link
Copy Markdown
Collaborator

thanks for contributing

@alejandro-vaz
alejandro-vaz added this pull request to the merge queue Aug 31, 2026
Merged via the queue into servo:v2 with commit a36e922 Aug 31, 2026
6 checks passed
@jdm

jdm commented Aug 31, 2026

Copy link
Copy Markdown
Member

What is the motivation here? This is an unusual practice.

@alejandro-vaz

Copy link
Copy Markdown
Collaborator

to make sure that dependency requirements don't change between patch versions

it seems that's what happened to criterion that caused #396 to not be able to compile and had to be reverted with #430 before we had to finally get back the PR with criterion 0.4

technically 0.7 would have sufficed, but it seemed a version requiring rustc 1.86+ was published as a patch or something along those lines, so after the 0.7 download (which required 1.80 at publish time) some dep updated it's version of clap_lex that required 1.86 invalidating 1.80 for the published version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lock all dependency versions to full semver

3 participants