Allow multi-platform builds for Singularity format - #128
Open
pditommaso wants to merge 1 commit into
Open
pditommaso wants to merge 1 commit into
pditommaso wants to merge 1 commit into
Conversation
Wave is gaining support for multi-architecture Singularity builds: two per-arch SIF images are built and pushed under a single `oras://` reference wrapped in an OCI image index, so one URL resolves to the right architecture at pull time. Remove the client-side guard that rejected `--singularity` combined with a multi-platform `--platform` value. Freeze mode remains mandatory for Singularity builds, and the `--mirror` and "nothing to build" conflicts are unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CLI rejected
--singularitycombined with a multi-platform--platformvalue(e.g.
linux/amd64,linux/arm64). Wave is gaining support for multi-architectureSingularity builds, so this client-side guard has to go.
With the service-side support, two per-arch SIF images are built and pushed under a
single
oras://reference wrapped in an OCI image index, so one URL resolves to theright architecture at pull time.
The service-side change is landing separately — see seqeralabs/wave#1132.
Changes
App.java: remove theisMultiPlatform() && singularityvalidation guard.AppTest.groovy: replace the test asserting the old rejection with one assertingthat
--singularity --freeze --platform linux/amd64,linux/arm64validates, plus atest confirming
--singularitywithout--freezeis still rejected.README.md: add a multi-architecture Singularity example next to the existing OCI one.Every other validation is untouched: freeze mode remains mandatory for Singularity,
--mirrorstill conflicts with multi-platform, and multi-platform still requires acontainer file or packages to build.
Caveat
Apptainer resolves the architecture at pull time (
apptainer pull --arch arm64 oras://...),whereas SingularityCE does not yet support platform selection for
oras://references.Testing
./gradlew test— 108 tests, 0 failures.🤖 Generated with Claude Code