feat: Add media.get, cameras.live_views and can_stream_live_video - #595
Conversation
Bump @seamapi/types to 1.1092.0 and regenerate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bde324dea1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "resolved": "https://registry.npmjs.org/@seamapi/types/-/types-1.1082.0.tgz", | ||
| "integrity": "sha512-QDuaHzjq+i/6yQ+fGs2jUmuZ8QomanqnLAuP2NULyGmfpTTeI/pEGkUp9YmRjUrbFoM8LHNT3ZmsFi8/2JJYmA==", | ||
| "version": "1.1092.0", | ||
| "resolved": "https://npm.pkg.github.com/download/@seamapi/types/1.1092.0/35cfbdb6dbfb0023a1ea6c6353ff90d51cc858e8", |
There was a problem hiding this comment.
On every clean CI test or formatting job, .github/actions/setup-node/action.yml runs npm ci while configuring only registry.npmjs.org and providing no GitHub Packages credentials. This resolved URL instead forces @seamapi/types through npm.pkg.github.com, whose npm registry requires authentication even for public packages, so dependency installation fails before any checks run. Regenerate the lockfile using the public npm registry URL.
Useful? React with 👍 / 👎.
| def get(media_id:, format: nil) | ||
| res = @client.get("/media/get", {media_id: media_id, format: format}.compact) | ||
|
|
||
| Seam::Resources::Media.load_from_response(res.body["media"]) |
There was a problem hiding this comment.
When callers use the documented format: "redirect", /media/get returns a 302 rather than a JSON body containing media, but this method unconditionally indexes res.body["media"]. The HTTP stack has no redirect-following middleware, so the advertised option yields an empty or non-hash body and raises instead of exposing the redirect; either omit this option from the SDK or return a suitable raw redirect result for that format.
Useful? React with 👍 / 👎.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 participants
Bumps
@seamapi/types1.1082.0 -> 1.1092.0 and regenerates.New in the SDK:
client.media.get,client.cameras.live_views.{create,offer,stop}, theMedia/CameraLiveViewSession/CameraLiveViewAnswerresources, andcan_stream_live_videoon devices. Dependabot's bumps had stopped at 1.1082.0, which predates/media/get.Generated locally with
npm run generate; formatting is left to the Generate workflow (no Ruby 3 toolchain locally).🤖 Generated with Claude Code