feat: Add media.get, cameras.live_views and can_stream_live_video - #656
Conversation
Bump @seamapi/types to 1.1092.0 and @seamapi/blueprint to ^1.12.0 and regenerate. The media route class shares its name with the media resource, so the route module now imports the resource under an alias. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4676e049c9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| res = self.client.get("/media/get", params=params) | ||
|
|
||
| return MediaResource.from_dict(unwrap(res, "media", "/media/get")) |
There was a problem hiding this comment.
When a caller passes format="redirect", the endpoint returns a 302 instead of a { "media": ... } payload. With the default HTTP client this is handled as a non-2xx error; if redirect following is enabled, the client returns the downloaded non-JSON body instead. The unconditional unwrap therefore makes the advertised redirect mode fail for both sync and async callers, so this path must bypass normal MediaResource decoding.
Useful? React with 👍 / 👎.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 participant
Bumps
@seamapi/types1.1047.0 -> 1.1092.0 and@seamapi/blueprintto ^1.12.0, then regenerates.New in the SDK:
seam.media.get,seam.cameras.live_views.{create,offer,stop}, theMedia/CameraLiveViewSession/CameraLiveViewAnswerresources, andcan_stream_live_videoon devices. Also picks up the docs URL move to www.seam.co/docs and other API changes since 1.1047.0.Codegen fix: the
Mediaroute class has the same name as theMediaresource, so the generatedseam/routes/media.pyredefinedMediaand failed pylint/mypy.codegen/lib/layouts/route.tsnow imports a resource that collides with its route class as<Name>Resource. No other route is affected.Locally: pylint 10/10, mypy clean, black clean, pytest 278 passed.
Supersedes #650.
🤖 Generated with Claude Code