You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Negative iteration counts can trigger SIZE_MAX output lines instead of being rejected, while documented options are unrecognized and the help fallback references a missing manual.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
The documented --message option is rejected, the help fallback depends on a missing file, and the unseeded random generator repeats the same update sequence across invocations.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Seed the random generator before generating actions
ud/c/ud.c:37
rand_range() calls rand(), but this program never seeds the generator. Consequently, separate invocations with the same arguments always choose the same actions, extensions, and messages, rather than varying the fake update sequence. Call the existing seed() helper once before work(), as the other randomized utilities do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So basically all the outputs take this form:
<action>: <msg>.<extension>.