Skip to content

Fix: validate and quote server-supplied SQL identifiers - #729

Merged
andrewtavis merged 2 commits into
scribe-org:mainfrom
Roniscend:fix_sql
Oct 21, 2026
Merged

andrewtavis merged 2 commits into
scribe-org:mainfrom
Roniscend:fix_sql

Conversation

@Roniscend

Copy link
Copy Markdown
Collaborator

Description

Server-supplied table and column names are now checked and quoted before being used in the local database.
Fixes: #724

Signed-off-by: Owm <owmdubey163@gmail.com>
@Roniscend Roniscend added the no-changelog No changelog entry is needed for this pull request label Oct 18, 2026

@andrewtavis andrewtavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Thanks for the update here and making the application more secure, @Roniscend! This all looks good on my end. We'll verify that all this is working once the server is up and running again :)

@andrewtavis
andrewtavis merged commit df31374 into scribe-org:main Oct 21, 2026
7 checks passed
@Roniscend

Copy link
Copy Markdown
Collaborator Author

praise: Thanks for the update here and making the application more secure, @Roniscend! This all looks good on my end. We'll verify that all this is working once the server is up and running again :)

Sure, Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No changelog entry is needed for this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Server-supplied table and column names are pasted unvalidated into SQL

2 participants