[pull] main from daijro:main - #27
Merged
Merged
Conversation
A job whose `if` has no status function gets an implicit success(), which is false when any job upstream of it was skipped, not only its direct needs. promote-browser is skipped on every push, so the first prerelease (run 36641558167) published camoufox 0.5.7b1 to PyPI and then skipped publish-npm and tag-library. `tests` is skipped on every tag, so a vX.Y.Z tag would have skipped build-library and published nothing. build-library, promote-browser, publish-npm and tag-library now start their `if` with !cancelled() and check the results they depend on. A test walks release.yml's needs graph and fails if either channel has such a job without a guard. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
npm reads `npm-dist/<file>.tgz` as a GitHub owner/repo shorthand and tries to clone it over ssh. The first run to reach publish-npm (36667788487, after #814) failed that way: PyPI got camoufox 0.5.7b2, npm got nothing, and tag-library was skipped. `./npm-dist/*.tgz` publishes the tarball. A test checks every `npm publish` in release.yml is given a local path. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 馃挅 Please sponsor : )