Make InvalidNameError copyable and picklable - #599
Open
eeshsaxena wants to merge 1 commit into
Open
Conversation
InvalidNameError takes name and reason, but its base only stores the formatted message in args, so copy.deepcopy and pickle rebuild it with a single argument and raise TypeError. That surfaces through normal parsing: a failed name is kept in a MiddlewareErrorBlock, and a later middleware like SortBlocksByTypeAndKeyMiddleware deepcopies the library. Store name and reason and add __reduce__ so the exception round-trips.
Author
|
Hi! Gentle nudge on this one whenever you have some bandwidth. It's a small, self-contained fix ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InvalidNameErrorcan't be copied or pickled, which crashes normal parsing:Its
__init__takesnameandreasonbut the baseValueErroronly keeps the formatted message inargs, so deepcopy/pickle rebuild it with a single argument. This surfaces through the public API: a failed name is stored in aMiddlewareErrorBlock, and a later middleware likeSortBlocksByTypeAndKeyMiddlewaredeepcopies the whole library, so any bad author name plus that middleware raisesTypeErrorout ofparse_string. I storename/reasonand add__reduce__so it round-trips. Added a test.