Write connector EMU coordinates as integers - #1143
Open
DSeaStar wants to merge 1 commit into
Open
Conversation
OOXML a:off/a:ext attributes are integers. add_connector() often receives floats (for example shape.height / 2), which were interpolated into XML and produced files PowerPoint and Google Slides reject.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1058.
add_connector()writesa:off/a:extby interpolating the computed EMUs into XML. Those values are often floats in real use (shape.height / 2, mixedInchesarithmetic), and OOXML requires integer coordinates. The resultingx="123.5"files open in some viewers but PowerPoint and Google Slides reject them.Steve suggested coercing at the write site (
int(x)/int(y)/int(cx)/int(cy)). That matches how pictures already emit%%d. Existing integer cases are unchanged; a float case is added to the_add_cxnSpfixture.