Accept level names in any case - #210
Open
sappelhoff wants to merge 1 commit into
Open
Conversation
The stdlib only knows upper-case level names, so setup_logging("warning")
raised ValueError: Unknown level: 'warning'. MNE accepts any case for the same
argument, and so should we -- lower case is the spelling people reach for, and
it is what the docs of the sibling packages in this stack now show.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
=======================================
Coverage 97.92% 97.92%
=======================================
Files 8 8
Lines 869 869
=======================================
Hits 851 851
Misses 18 18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup_logging("warning")raised, because the stdlib only knows upper-case level names:mne.set_log_level("warning")accepts it, lower case is the spelling people reach for, and itis what the sibling packages in this stack show in their docs. So the level is upper-cased when
it is a string, and passed through untouched when it is an int.
Tested for
"warning","WARNING","Warning"andlogging.WARNING.pytest tests/test_logging.py: 57 passed.ruff checkclean.