W-23814642- resolve npm from PATH only, excluding CWD - #1255
Merged
Conversation
WillieRuemmele
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Summary
npmviawhichand reject if it resolves to CWD inoutdatedCliVersionCheckexecFilewith the resolved absolute path instead ofexecwith a bare command name{ shell: true }only when the resolved path is a.cmd/.batfileTest plan
npm.exein CWD no longer executes viasf doctorsf doctordiagnostics run normally from a clean directoryWhat issues does this PR fix or reference?
@W-23814642@