Compare the security terminal observation at second granularity - #250
Merged
Conversation
…granularity The publisher refused every live publish with 'security terminal observation time is invalid'. The security receipt records produced_at with microseconds while the terminal receipt records observed_at at whole seconds, so a terminal written in the same second as the receipt (the normal case for a fast collector: 12:08:08.576 vs 12:08:08) compared as earlier. The order check now truncates produced_at to the second; a terminal a full second earlier, or in the future, is still refused. Unit test covers all four cases.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First live publish attempts (2026-09-02, after operator-scripts #65 and #66) were refused with 'security terminal observation time is invalid'. The security receipt's produced_at carries microseconds; the terminal receipt's observed_at is whole seconds; when the collector writes both within the same second the terminal compares as earlier. The order check now truncates produced_at to the second. A terminal a full second earlier, or in the future, is still refused. Unit test added; full suite 3660+ passing locally. After merge, operator-scripts must move EXPECTED_REF to the merge commit for the nightly publish to use this.