Skip to content

Fix CodeQL registry validation temp write - #249

Merged
saagpatel merged 1 commit into
mainfrom
codex/ghra-codeql-466-inmemory-registry-20260902
Sep 2, 2026
Merged

Fix CodeQL registry validation temp write#249
saagpatel merged 1 commit into
mainfrom
codex/ghra-codeql-466-inmemory-registry-20260902

Conversation

@saagpatel

Copy link
Copy Markdown
Owner

Summary

  • add an in-memory registry markdown parser entrypoint while preserving parse_registry(path)
  • validate generated registry markdown without writing the generated content to a temporary file
  • add regression coverage that validate_registry_markdown does not create the compatibility temp path

Security

  • Targets CodeQL alert #466: py/clear-text-storage-sensitive-data at src/github_repo_auditor/portfolio_truth_validate.py:2328
  • Removes the temp-file sink that stored generated registry Markdown during validation

Verification

  • PYTHONPATH=src /opt/homebrew/bin/pytest tests/test_registry_parser.py tests/test_portfolio_truth.py::test_rendered_registry_round_trips_through_parser tests/test_portfolio_truth.py::test_registry_validation_does_not_write_temp_markdown tests/test_portfolio_truth.py::test_registry_render_surfaces_security_and_round_trips -q
  • PYTHONPATH=src /opt/homebrew/bin/pytest tests/test_portfolio_truth.py -q
  • uv run --no-sync ruff check .
  • git diff --check

Notes

  • CodeQL/provider closure is not claimed until GitHub checks run on this PR and the alert is fixed or dismissed through the provider.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T08:07:13.268031Z 393222f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@saagpatel
saagpatel merged commit 9a4fbbb into main Sep 2, 2026
4 checks passed
@saagpatel
saagpatel deleted the codex/ghra-codeql-466-inmemory-registry-20260902 branch September 2, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant