Repository navigation
feat(mobile): add voice input to task forms and confirmation notifications - #172
Merged
Merged
Conversation
…tions - Add MobileTaskVoiceButton with a review sheet for dictating task descriptions in the task form, quick add, and AI draft. - Dispatch permission-ask hooks when a confirmation tool is waiting for approval so mobile receives notifications and routes to the thread. - Open the project task board when a sidebar project is clicked instead of toggling expansion. - Show newest tool calls first in the tool activity sheet. - Hide the sessions toolbar while a thread is selected on mobile.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds voice dictation to mobile task entry, sends permission notifications when a confirmation tool is waiting for the user, and includes two desktop/mobile UI fixes that were pending in the working tree.
Changes
Mobile: voice input for tasks
MobileTaskVoiceButtoninRxCodeMobile/Views/MobileVoiceInputSheet.swift. It opens a large sheet that reuses the existingMobileVoiceInputSessionandmobileVoiceInputmodifier, so recording, transcription, and haptics follow the same path as the other voice input.MobileTaskFormView.swift: the task description field.MobileTaskFormView.swift:MobileQuickAddTaskView.MobileAIDraftSheet.swift: the AI draft prompt.Task descriptionandUse Textstrings toLocalizable.xcstrings.Confirmation tool notifications
AppState+IDEPromptTools.swift: when a confirmation prompt is queued and its continuation is still pending, the app now dispatcheshookManager.dispatchPermissionAskwith the tool use ID, tool name, session ID, project ID, and project name.@MainActortask and is skipped if the continuation was already resolved or cancelled.Desktop: sidebar project click
ProjectTreeView.swift: clicking a project row now opens that project's task board (generalRoute = .tasks, setstaskDetailProjectId, and callsappState.focusProject). It no longer toggles expansion with an animation.Tool activity sheet order
ToolActivityGroupView.swift: the sheet lists tool calls newest first.isFirstandisLastare swapped to match the reversed order so the timeline connector lines still render correctly.Mobile: sessions toolbar
SessionsList.swift: the sessions toolbar is hidden while a thread is selected, so it no longer overlaps the open thread on mobile.Testing
Not run, per request. Build, unit tests, and lint have not been verified for this PR.
Notes for reviewers
hookManager.dispatchPermissionAsk. Check that mobile receives the notification and opens the correct thread for a confirmation that arrives while the app is backgrounded.origin/mainwas a no-op because the branch was created from the latestmain(65f71c6) with no prior commits ahead.