fix: add support for QNX8 - #670
Open
lambinoo wants to merge 1 commit into
Open
Conversation
lambinoo
changed the title
lambinoo
force-pushed
the
fix-qnx-iosock-support
branch
from
September 4, 2026 11:32
a84efe4 to
b8acf7c
Compare
Thomasdezeeuw
approved these changes
Sep 4, 2026
Thomasdezeeuw
left a comment
Thomasdezeeuw
left a comment
Collaborator
There was a problem hiding this comment.
Code changes LGTM, but we'll have to wait on rust-lang/libc#5469 before we can merge this.
Maybe we want to add a CI job for QNX to catch this in future?
Author
|
The QNX toolchain requires licenses. I'm not sure what's Blackberry's stand on providing free licenses for open-source projects. But that would be good for sure! It is a Tier 3 target tho, so there's no project-wide mandate to keep this working |
Collaborator
|
We can do a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working with socket2 on more modern QNX8 targets (with io-sock networking stack), I noticed the crate does not compile because of some missing cfgs, which are caused by this change in the rustc:
rust-lang/rust#158449
This PR requires some extra changes to be merged in the libc crate to actually work:
https://github.com/rust-lang/libc/pull/5469/changes
Notably, this change does not affect QNX7 with io-sock networking stack, which I think compiles but is quite broken. netinet headers include a lot of changes in io-sock (as they rebased on a new BSD version), so it's definitely using bad constants for some things.