Conversation
Follows rundeck and rundeckpro onto Java 25. The Gradle wrapper goes to 9.6.0, the Java source/target moves to 25 where this build declares it, and the workflows that run the build move with it -- a build targeting 25 is no use if CI still hands it a 17 JVM. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
Update the workflow labels and regenerate or remove the stale Gradle build log.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates the plugin build from Gradle 8.14.x/Java 17 to Gradle 9.6.0/Java 25.
Changes:
- Upgrades the Gradle wrapper to 9.6.0.
- Updates build and release workflows to Java 25.
- Adds a Gradle build log artifact.
File summaries
| File | Summary | Review notes |
|---|---|---|
gradle/wrapper/gradle-wrapper.properties |
Uses Gradle 9.6.0. | — |
.github/workflows/build.yml |
Configures Java 25 for CI builds. | Nit (3 votes): Rename the displayed setup step from “Set up JDK 17” to “Set up JDK 25”. |
.github/workflows/release.yml |
Configures Java 25 for releases. | Nit (3 votes): Rename the displayed setup step from “Set up JDK 17” to “Set up JDK 25”. |
temp/20260914-160154-gradle-build.log |
Adds recorded build output. | Nit (3 votes): Regenerate with Gradle 9.6.0 or remove it; the current log references Gradle 8.14.5. |
Review details
- Files reviewed: 3/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| uses: actions/setup-java@v5 | ||
| with: | ||
| java-version: '17' | ||
| java-version: '25' |
| uses: actions/setup-java@v5 | ||
| with: | ||
| java-version: '17' | ||
| java-version: '25' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Follows
rundeckandrundeckproonto Java 25. One of 23 plugin repos moving together; the change is the same in each.java-versionThe workflows move with the build deliberately: a build targeting 25 is no use if CI still hands it a 17 JVM.
Testing
./gradlew clean buildpasses on JDK 25 (Zulu 25.0.4).Not verified here: publishing, and the plugin running inside a Rundeck instance.