Conversation
The last release, 0.3.0, went out in June 2024. Since then `main` gained packwerk 3 compatibility, but none of it is installable, so consumers have to pin the gem to a git SHA (#89). Minor rather than patch: three changes since 0.3.0 are breaking for consumers. - `required_ruby_version` raised from >= 2.7 to >= 3.3 - the `packwerk` dependency raised from >= 2.2.1 to >= 3 - `sorbet-runtime` dropped as a runtime dependency, after the checkers migrated to RBS comment annotations (#68, #71) Verified on this branch against packwerk 3.3.1: 88 tests pass, rubocop reports no offenses across 67 files, and `srb tc` is clean. The gem builds as 0.4.0 and `lib/` no longer references sorbet-runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #89.
0.3.0shipped in June 2024. Everything since — including packwerk 3 compatibility — has sat onmainunreleased, so consumers have to pin the gem to a git SHA. @sliminas reported this in #89.Why nothing published on its own
Nothing is broken in the pipeline.
.github/workflows/cd.ymlruns after every successful CI run onmainand delegates toshared-config, which runsrake releaseviadiscourse/publish-rubygems-action. That publishes only when the gemspec version differs from what is on RubyGems, so with the version left at0.3.0every CD run since June 2024 has succeeded and correctly done nothing. Bumping the version is the whole release.Why minor, not patch
Three changes since
0.3.0are breaking for consumers, so this takes the breaking slot in0.x:0.3.0mainrequired_ruby_version>= 2.7>= 3.3packwerk>= 2.2.1>= 3sorbet-runtimeThe
sorbet-runtimeremoval is the fix #89 is asking for: packwerk 3.3 dropped the dependency, and the checkers moved to RBS comment annotations in #68 and #71.lib/no longer referencessorbet-runtimeat all —sorbetandsorbet-runtimeremain development dependencies only.Verification
Run on this branch, against the locked
packwerk 3.3.1:Gemfile.lockis included because the gemspec is a path dependency, so the lock pins the gem's own version and would otherwise go stale.What merging does
Merging publishes. CI will run on
main, CD will see0.4.0against the published0.3.0, then tagv0.4.0, push the gem to RubyGems, and cut a GitHub release with generated notes. Worth knowing before you hit the button, since it is not easily undone.CHANGELOG.mdonly points at the releases page, so it needs no edit.Out of scope:
gem buildalso emits two pre-existing cosmetic gemspec warnings (descriptionandsummaryare identical, andhomepage_uriduplicatessource_code_uri). Unrelated to the release, so I left them alone.Sent with Claude Code