Repository navigation
fix(deps): update @wordpress/scripts to 37 and refresh stale npm overrides - #842
Open
aryanjasala wants to merge 2 commits into
Open
aryanjasala wants to merge 2 commits into
aryanjasala wants to merge 2 commits into
Conversation
Moves @wordpress/scripts 36.0.0 to 37.0.0, @wordpress/babel-preset-default 8.56.0 to 10.0.0, @wordpress/browserslist-config 6.56.0 to 7.0.0 and @wordpress/interactivity 6.56.0 to 8.0.0. Breaking changes checked: scripts 37 bundles webpack-dev-server 6, and webpack.blocks.config.js only deletes the default proxy and sets port and allowedHosts, none of which v6 removed. Interactivity 7 drops data-wp-ignore, two-hyphen unique IDs and negated function calls; the theme uses none of them. The rest raise the Node floor to 22.13, which the Node 24 floor already meets. @wordpress/eslint-plugin stays on 27: @rtcamp/eslint-config 1.2.0 accepts only ^25 to ^27 as a peer. wp-scripts 37 keeps its own nested 28.
The overrides pinned the very versions Dependabot now flags: express's qs at 6.16.0 and copy-webpack-plugin's serialize-javascript at 7.0.5. They move to the patched 6.16.2 and 7.1.4, and markdownlint-cli's smol-toml is pinned to the patched 1.9.1, since wp-scripts 37 still asks for markdownlint-cli 0.49. The webpack-dev-server 5.2.6 override goes: wp-scripts 37 needs webpack-dev-server 6, which also drops sockjs, so the sockjs uuid override goes too. package-lock.json is resolved without user-level npm settings, as CI resolves it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Moves the theme to
@wordpress/scripts37 and its sibling packages, and fixesoverridesthat had started pinning the very versions Dependabot flags.Closes
N/A
Changes
@wordpress/scripts36.0.0 to 37.0.0,@wordpress/babel-preset-default8.56.0 to 10.0.0,@wordpress/browserslist-config6.56.0 to 7.0.0,@wordpress/interactivity6.56.0 to 8.0.0.@wordpress/eslint-pluginstays on 27.0.0:@rtcamp/eslint-config1.2.0 accepts only^25to^27as a peer.wp-scripts37 keeps its own nested 28.overrides:express>qs6.16.0 to 6.16.2 andcopy-webpack-plugin>serialize-javascript7.0.5 to 7.1.4 (both were pinned to the vulnerable versions),markdownlint-cli>smol-toml1.9.1 added. Thewebpack-dev-server5.2.6 override goes (wp-scripts 37 needs 6) and so does thesockjsone (webpack-dev-server 6 drops sockjs).Breaking changes checked: webpack-dev-server 6 removes nothing
webpack.blocks.config.jsuses (it deletes the default proxy and sets port and allowed hosts). Interactivity 7 removesdata-wp-ignore, two-hyphen unique IDs and negated function calls; the theme uses none of them. The rest raise the Node floor to 22.13, which the Node 24 floor meets.How I verified
npm cion Node 24 with CI's npm settings (no user.npmrc): no dependencyEBADENGINEwarnings.npm run build:prodproduces the same 18 files as the base branch.lint:cssandlint:package-jsonpass.lint:js(run outside the home directory): 0 errors, 6 warnings as onmain.webpack.blocks.config.jsloads with webpack-dev-server 6.1.0.npm audit: 0 critical, 0 high.