Repository navigation
fix(deps): update @wordpress/scripts to 37 and refresh stale npm overrides - #77
Open
aryanjasala wants to merge 1 commit into
Open
aryanjasala wants to merge 1 commit into
aryanjasala wants to merge 1 commit into
Conversation
…rides Moves @wordpress/scripts 36.0.0 to 37.0.0, @wordpress/babel-preset-default 8.47.0 to 10.0.0, @wordpress/browserslist-config 6.56.0 to 7.0.0, @wordpress/eslint-plugin 25.4.1 to 27.0.0, @wordpress/interactivity 6.56.0 to 8.0.0, @wordpress/server-side-render 6.28.0 to 7.0.0 and lint-staged 16.1.6 to 17.6.0. @wordpress/eslint-plugin stops at 27: @rtcamp/eslint-config 1.2.0 accepts only ^25 to ^27 as a peer. wp-scripts 37 keeps its own nested 28. Adds @wordpress/theme 4.0.0 as a dev dependency. It is a peer of @wordpress/stylelint-config 27, which this repo's legacy-peer-deps setting does not install, so Stylelint picked up the 2.3.0 copy the editor packages hoist and crashed loading its design tokens. The overrides pinned the very versions Dependabot flags: express's qs at 6.16.0 and copy-webpack-plugin's serialize-javascript at 7.0.5. They move to the patched 6.16.2 and 7.1.4, and markdownlint-cli's smol-toml is pinned to the patched 1.9.1. The webpack-dev-server 5.2.6 and sockjs uuid overrides go: wp-scripts 37 needs webpack-dev-server 6, which drops sockjs. Breaking changes checked: webpack-dev-server 6 removes nothing webpack.blocks.config.js uses; interactivity 7 removes data-wp-ignore, two-hyphen unique IDs and negated function calls, none of which the skeleton uses; eslint-plugin 26 and 27 change the esnext parser and the test-unit rules, both covered by @rtcamp/eslint-config's own Jest config; lint-staged 17 and the rest raise Node floors the Node 24 floor already meets.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Moves the skeleton to
@wordpress/scripts37 and its sibling packages, fixes a Stylelint crash that upgrade exposes, and fixesoverridesthat had started pinning the very versions Dependabot flags.Closes
N/A
Changes
@wordpress/scripts36.0.0 to 37.0.0,@wordpress/babel-preset-default8.47.0 to 10.0.0,@wordpress/browserslist-config6.56.0 to 7.0.0,@wordpress/eslint-plugin25.4.1 to 27.0.0,@wordpress/interactivity6.56.0 to 8.0.0,@wordpress/server-side-render6.28.0 to 7.0.0,lint-staged16.1.6 to 17.6.0.@wordpress/eslint-pluginstops at 27:@rtcamp/eslint-config1.2.0 accepts only^25to^27as a peer.@wordpress/theme4.0.0: a peer of@wordpress/stylelint-config27, which this repo'slegacy-peer-depssetting does not install, so Stylelint loaded the@wordpress/theme2.3.0 the editor packages hoist and crashed reading its design tokens (Cannot convert undefined or null to objectintheme-tokens.mjs). The editor packages keep their nested 2.3.0.overrides:express>qs6.16.2 andcopy-webpack-plugin>serialize-javascript7.1.4 (both were pinned to the vulnerable versions),markdownlint-cli>smol-toml1.9.1 added; thewebpack-dev-server5.2.6 andsockjsoverrides go (wp-scripts 37 needs webpack-dev-server 6, which drops sockjs).Breaking changes checked: webpack-dev-server 6 (nothing
webpack.blocks.config.jsuses), interactivity 7 (none of the removed directives are used), eslint-plugin 26 and 27 (esnext parser andtest-unitrules, covered by@rtcamp/eslint-config's own Jest config), lint-staged 17 and the rest (Node floors the Node 24 floor meets).How I verified
npm cion Node 24: no dependencyEBADENGINEwarnings.npm run build:prodproduces the same 34 files as the base branch.lint:css,lint:package-jsonpass;lint:js(run outside the home directory): 0 errors, 1 warning.test:jsfinds no tests, as onmain.webpack.blocks.config.jsloads with webpack-dev-server 6.1.0.katex(low; the fix needs 0.18 through markdownlint, a 0.x major) anddeepmerge(no fix released).npm audit: 0 critical, 0 high.Reviewer notes
@rtcamp/eslint-configand@rtcamp/stylelint-configpeer ranges are behind (@wordpress/eslint-pluginup to 27;@wordpress/stylelint-config^23.37.0while wp-scripts brings 27). Widening them is a wp-tooling change.