Add scale metadata attribute - #337
Merged
Merged
Conversation
JoOkuma
approved these changes
Sep 2, 2026
JoOkuma
left a comment
JoOkuma
left a comment
Member
There was a problem hiding this comment.
Hi @cmalinmayor, thanks for the PR.
I left a few minor comments, and I'm approving it so we can merge your reply to them.
Contributor
Author
|
@JoOkuma I'm good with those changes! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds an enum containing default constant keys for the scale and shape metadata, and some helper functions for manipulating on-disk metadata without loading the graph (mostly for testing purposes).
Technically, I would argue that both scale and shape are the properties of a certain masks column (or even, in the case of scale, of the masks themselves). But, the global property covers most use cases where all masks come from the same segmentation