Fix bug where the refresh interval setting was displayed as "never" and could get overwritten on save for values outside the options list (#10292) - #10322
Open
taylorsatula wants to merge 2 commits into
Conversation
…nd could get overwritten on save for values outside the options list (roundcube#10292)
Member
|
Please, do not include Changelog entries, they will produce a conflict whenever something is added there. |
Author
Sorry about that! I'll keep things out of changelog in future PRs. Do you want me to edit this one or can it be saved with a cherrypick? |
alecpl
reviewed
Sep 19, 2026
| $labels['showinlineimages'] = 'Display attached images below the message'; | ||
| $labels['autosavedraft'] = 'Automatically save draft'; | ||
| $labels['everynminutes'] = 'every $n minute(s)'; | ||
| $labels['everynseconds'] = 'every $n second(s)'; |
Member
There was a problem hiding this comment.
Setting the interval to 1 second really would not make much sense. So, this can be just "every $n seconds". Also, we probably should introduce some minimum value, e.g. 10 seconds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10292
The select only offered 0 (never) and whole minutes [1,3,5,10,15,30,60], so values like 30 seconds or 2 minutes rendered as "never", and saving the form stored 0, wiping the setting. Make the select seconds-based (same pattern as draft_autosave in the same function), add the current interval as an extra option when it's not in the list, and store the posted value as-is. Adds an everynseconds label for sub-minute values.