2.1.1 - #75
Merged
Merged
2.1.1#75
Conversation
- Added `singlePageExpress.htmlValidateConfig`, an [html-validate](https://html-validate.org/) config to hand the `htmlValidator` param. It is `html-validate:recommended` with `attribute-boolean-style` and `attribute-empty-style` turned off, by default. - Added `topbarDelay`, which is how long a navigation has to still be working before the top bar appears at all, defaulting to 250ms. Set it to `0` for the previous behavior of showing the bar the moment a navigation starts. - Fixed the top bar vanishing the moment a view transition started and reappearing when it ended. - Fixed the listener that scrolled the page after a view transition never being removed. Each navigation added another one, so the tenth navigation ran ten of them, each restoring the scroll position of whichever page it had been created for. - Updated dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
singlePageExpress.htmlValidateConfig, an html-validate config to hand thehtmlValidatorparam. It ishtml-validate:recommendedwithattribute-boolean-styleandattribute-empty-styleturned off, by default.topbarDelay, which is how long a navigation has to still be working before the top bar appears at all, defaulting to 250ms. Set it to0for the previous behavior of showing the bar the moment a navigation starts.