0.34.1 - #1680
Merged
Merged
0.34.1#1680
Conversation
- Fixed a bug that caused every option supplied in `css.compiler.options` to be silently ignored when using Sass. Roosevelt was reading `css.compiler.params`, which is not a param, so options such as `style` never reached the compiler. The other preprocessors were unaffected. - Fixed the import paths supplied in `css.compiler.options` being replaced by the app's CSS folder, which is `loadPaths` for Sass and `paths` for Less and Stylus. The CSS folder is now added to them instead. - Fixed Roosevelt loading its own copy of a package the app is supposed to supply, instead of the app's, whenever Roosevelt has a copy of its own. That covers Express, the view engine, the CSS preprocessor, and the JS bundler. An ordinary install was unaffected, but a Roosevelt linked to a clone, copied in by `devSync.js`, or installed by a package manager that keeps each package's dependencies apart, such as pnpm, would quietly run its development copies rather than the versions the app installed. They are now loaded from the app, with Roosevelt's own copy as the fallback. - Fixed a failed render being sent to the visitor as JSON, stack trace included, instead of going to the app's error page, whenever HTML minification was enabled, which it is by default in production. A failed render with a callback also no longer tries to minify HTML that was never produced, and `res.render(view, callback)` with no options is now minified like any other render. - Fixed `roosevelt-generate-certs` and `roosevelt-generate-session-secret` looking for the app four directories up from Roosevelt's own files when not given `--appDir`. They now use the directory the command was run from, the same as `roosevelt-migrate-config`. - Updated dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
css.compiler.optionsto be silently ignored when using Sass. Roosevelt was readingcss.compiler.params, which is not a param, so options such asstylenever reached the compiler. The other preprocessors were unaffected.css.compiler.optionsbeing replaced by the app's CSS folder, which isloadPathsfor Sass andpathsfor Less and Stylus. The CSS folder is now added to them instead.devSync.js, or installed by a package manager that keeps each package's dependencies apart, such as pnpm, would quietly run its development copies rather than the versions the app installed. They are now loaded from the app, with Roosevelt's own copy as the fallback.res.render(view, callback)with no options is now minified like any other render.roosevelt-generate-certsandroosevelt-generate-session-secretlooking for the app four directories up from Roosevelt's own files when not given--appDir. They now use the directory the command was run from, the same asroosevelt-migrate-config.