Skip to content

test: strengthen decision assertions - #271

Merged
rlippmann merged 1 commit into
mainfrom
test_quality
Sep 5, 2026
Merged

test: strengthen decision assertions#271
rlippmann merged 1 commit into
mainfrom
test_quality

Conversation

@rlippmann

Copy link
Copy Markdown
Owner

What changed

  • Strengthen the shared Decision assertion helper to check supplied public fields.
  • Update primary Engine tests to assert changed, failure types, rejected directives, ordered repairs, and messages.

Why

  • Prevent tests from passing when structured Decision data is incorrect while the kind or message remains unchanged.

Checklist

  • pre-commit run (uv run pre-commit run --all-files)
  • tests pass (uv run pytest)

@codecov

codecov Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (142b655) to head (ce4e11d).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #271   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          783       783           
=========================================
  Hits           783       783           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rlippmann
rlippmann merged commit 4408967 into main Sep 5, 2026
20 checks passed
@rlippmann
rlippmann deleted the test_quality branch September 5, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant