Repository navigation
Conversation
iperev
force-pushed
the
refactor/remove-unused-publisher
branch
from
October 12, 2026 09:32
b92f95d to
3b76155
Compare
…stics unexpected_failure records now carry the innermost first-party frame's module, code qualname and line (sourceModule/sourceQualname/sourceLine, null when no ci_coordinator source frame exists) and a 16-hex failureFingerprint: truncated SHA-256 over the admitted stage, the exception class module and qualname, and at most eight innermost untruncated first-party coordinates. The module is derived as text from the code filename relative to the loaded package directory; frame globals are a reserved dynamic-import authority and are not read. Messages, arguments, notes, locals, file paths and provider data stay excluded; emission stays one record per failure, and no metric label is added. The projection is contained inside the diagnostic owner: if the exception object raises an Exception while its class name, traceback or class identity is read, or supplies a non-interpreter traceback, the record degrades to the class-only form (null fingerprint and coordinates), the logger failure counter is incremented, and the caller's redacted outcome is unchanged. Cancellation still propagates. Emitted coordinates are truncated to 256 characters after hashing, so prefix-sharing modules keep distinct fingerprints. Requirement impact: REQ-CI-RUNTIME-034 invariant extended for build identity, source coordinates, the fingerprint and degraded projection. Provisional owner decision (2026-10-11): CI-066 Q9(a). Per-fingerprint rate limiting is not implemented; log-storm absence under load remains a CI-069 measurement.
iperev
force-pushed
the
feat/private-diagnostic-coordinates
branch
from
October 12, 2026 09:34
8d40033 to
339a0fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
CI-066 asks for useful private failure diagnostics that still exclude messages, arguments, locals, secrets and raw provider data. This implements the provisional owner decision (2026-10-11), CI-066 Q9(a).
What changed
unexpected_failureaddssourceModule,sourceQualnameandsourceLine. These name the innermost first-party frame and are null when there is none.failureFingerprint: 16 hex characters of SHA-256 over the stage, the exception class, and at most eight innermost first-party coordinates, hashed in full. The emitted coordinates are cut to 256 characters.observability.md, recoverable-service-boundaries, REQ-CI-RUNTIME-034 and the CI-066 ROADMAP row are updated.Expected result
Non-claims
Provisional decisions: provisional owner decision (2026-10-11), CI-066 Q9(a).
Independent review: gpt-6-astra (xhigh); findings addressed or rejected with reasons in the single commit. Provisional owner decisions (2026-10-11) are labelled in the changed documents.