Repository navigation
fix(renovate): skip the release-age soak for reqstool's own packages - #286
Merged
Merged
Conversation
minimumReleaseAge exists to catch a bad third-party release before it is adopted. Applied to our own packages it only delays the org: bundling reqstool 1.0.0 into reqstool-vscode would have waited 7 days as a major. Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
minimumReleaseAge(3 days for minor/patch, 7 for major) exists to catch a bad third-party release before we adopt it. On our own packages it only delays the org. Bundling reqstool 1.0.0 into reqstool-vscode would have waited 7 days as a major, so it was bumped by hand (reqstool-vscode#162).The new rule sits last in
packageRules, because the last match wins, and resets the age for:/^@reqstool\\//@reqstool/*/^io\\.github\\.reqstool[.:]/io.github.reqstool:*, the Gradle pluginio.github.reqstool.gradle-pluginAutomerge is unchanged: minor and patch bumps still auto-merge once CI is green, and majors still need a manual merge.
Test plan
renovate-config-validator --strictpasses locally