Conversation
Work-package checkpoint. Existing citizen-related work is preserved but phase 4 is deferred pending a separate decision; institutional delivery must use stock ThunderID. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Work-package checkpoint. Existing citizen-related work is preserved but phase 4 is deferred pending a separate decision; institutional delivery must use stock ThunderID. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
jeremi
marked this pull request as ready for review
September 12, 2026 18:22
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39e711b229
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jeremi
marked this pull request as draft
September 12, 2026 19:39
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the optional identity profile to the native eSignet 2.0 BREG provider candidate and issuer-neutral token-client configuration. The ordinary portal relying-party flow validates signed identity responses, keeps the provider's existing consented
individual_idclaim contract, and maps that opaque value to the governed BREG person reference. Provider candidate images must be built explicitly; no unpublished release digest is invented.Add owned local fixture tooling and protocol tests, update local and hosted configuration, and preserve the existing published Stack runtime pins. This draft does not integrate the deferred ThunderID citizen federation fork or claim that the legacy published runtime is Mint-free.
Validation:
just lint,just test, and config-onlyjust composepass. Test gate includes 317 Python tests, three protocol helper tests, 163 portal tests and 62 home tests. Focused BREG/seed/topology tests also pass. Compose validation starts no services; no complete live lab smoke or deployment is claimed. The new provider contract remains paired with the companion authenticator draft PR.Rebased on freshly fetched origin/main before pushing. No merge, publication, deployment or tag is included.