feat(docs): gate Casework tutorials with the runner that reads the page as its spec - #1573
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8369dc18ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
5bc2a07 to
4255b80
Compare
…ge as its spec first-casework now declares tutorial_test with the casework toolset and carries its own checks: the create and decision status lines as output blocks, and the answered result as a JSON excerpt, replacing the assertion list in check-casework-tutorial.sh. The start page and the BReg review guide declare why they are skipped. The casework toolset serves casework, caseworkctl, breg, and bregctl, and stops Casework sessions before BReg ones. Because it includes breg, a page running both belongs to its gate; a page running a toolset's commands under a toolset that does not serve them is now refused, so toolset: none can no longer take a page out of every gate. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
The runner's tests import yaml and remark, which the job never installed, and the changelog evidence anchor still cited the deleted shell gate. Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
4255b80 to
1a66abe
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a66abecd4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Stacked on #1572. Until that merges, this PR also shows its commits; review only the last one, "feat(docs): gate Casework tutorials with the runner that reads the page as its spec".
What changes
tutorials/first-caseworkdeclarestutorial_test: {toolset: casework}and carries its own checks, replacing the assertion list incheck-casework-tutorial.sh:HTTP 201after the create andHTTP 204after the decision, astext test-expectoutput blocks the reader now sees too;json test-excerpt(status: answered,outcome: confirmed).start/caseworkandtutorials/review-breg-changes-in-caseworkdeclare why they are skipped (the first moves frombregtocasework, since it runs both products' commands).caseworktoolset intutorial-runner/toolsets.mjs: servescasework,caseworkctl,breg,bregctl(fromCASEWORK_BIN,CASEWORKCTL_BIN,BREG_BIN,BREGCTL_BIN, all or none, else built from source) and stops Casework sessions before BReg ones.bregandcaseworknow share one small factory.caseworkincludesbreg), and a page running a toolset's commands under a toolset that does not serve them is refused. Before this,toolset: noneon a page runningbregctlescaped every gate.check-casework-tutorial.shand its test. CI,ci_changes.pyrouting, and the gates inventory point atrun-tutorial.mjs --gate casework.test:tutorial:bregbecomestest:tutorial:runner, used by both jobs.Verification
npm test(638 pass: 661 minus the 26 removed bash-gate tests plus 3 new),npm run test:tutorial:runner(64 pass)check:tutorial:{breg,casework,evidence}:dry-run,check:content,check:markdown, vale on both changed pages: cleanpython3 -m unittest discover -s .github/scripts -p test_ci_changes.py(119 OK),test_check_gates_inventory.pyOK,check-gates-inventory.py(219 gates)gate PASS: 1 journey replayed, 2 pages skipped, about 11 s, no token in the log, no dev container left behindHTTP 201toHTTP 202andconfirmedtorejectedfails both checks by line with the actual value