Skip to content

Scheduling appointment references: review follow-ups from #1766 #1769

Description

@jeremi

Non-blocking findings from the review of #1766 (the Scheduling externalReferences and appointment listing work). Line numbers refer to 8ae9467.

  1. SEC-08's primary negative test now runs only in the merge queue. It moved from a database-free test to a Postgres-only one (products/scheduling/contracts/security-invariant-matrix.yaml:151), and PR CI does not run that suite by default. Keep a database-free refusal test alongside it.
  2. The OpenAPI schema doesn't publish the runtime's limits. ExternalReference in products/scheduling/generated/registry-scheduling.openapi.json:472 omits the identifier pattern the runtime enforces and the per-appointment item bound, so clients cannot validate either before sending.
  3. Listing scope is narrower than scheduling: link an appointment to a Casework case (externalReferences) #1764 describes. GET /v1/appointments lists only the caller's own bookings. That matches the README, but scheduling: link an appointment to a Casework case (externalReferences) #1764 frames it as "a case can find its appointments": another principal working the same case cannot find them. Decide whether that is the intended scope and document it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions