Fix SchemaStore matching for nonstandard YAML filenames - #1347
Merged
Merged
Conversation
Signed-off-by: Morgan Chang <shin19991207@gmail.com>
datho7561
approved these changes
Sep 22, 2026
datho7561
left a comment
datho7561
left a comment
Contributor
There was a problem hiding this comment.
Looks good and works well. Thanks, Morgan!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
SchemaStore associations were previously retained only when their fileMatch patterns is empty or contained
.yaml,.yml, or a pattern supplied through thefiles.associationssetting. This excluded valid YAML files with nonstandard or extensionless names, such as.clang-format.This PR changes SchemaStore catalog filtering to exclude file matches with JSON-specific extensions (
.json,.jsonc, and.json5) instead of requiring a known YAML extension.It also removes the now unused
SettingsState.fileExtensionsandfiles.associations.What issues does this PR fix or reference?
Fixes redhat-developer/vscode-yaml#1124
Is it tested? How?