Skip to content

Stripping of table values is now behind a config option - #78

Closed
sjanusz-r7 wants to merge 1 commit into
rapid7:masterfrom
sjanusz-r7:indent-changes
Closed

sjanusz-r7 wants to merge 1 commit into
rapid7:masterfrom
sjanusz-r7:indent-changes

Conversation

@sjanusz-r7

@sjanusz-r7 sjanusz-r7 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

In draft for a little bit as I figure out maybe some alternative approaches/make this nicer.

This PR allows us to configure the stripping of whitespaces in columns.

Previously, the string values would be stripped when being inserted into the row by default. This behaviour is now configurable, with being on by default to maintain already existing expectations.

This allows us to do the following in Framework (future PR):

> services --tree
127.0.0.1        8800   tcp    tcp            open
127.0.0.1        8800   tcp    '- http        open
127.0.0.1        8800   tcp       '- jenkins  open

Another approach could have been to potentially attach an indent metadata to each cell/value in a row, and let the table handle this automatically. After poking at it, it seems to be more difficult though and I'm unsure about the payoff.

Testing

  • Passing CI
  • Verifying this behaviour makes sense for this usecase above
  • bundle exec rspec spec

@sjanusz-r7
sjanusz-r7 marked this pull request as draft August 27, 2026 13:51
@sjanusz-r7 sjanusz-r7 closed this Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant