Repository navigation
ci: build RocksDB with -include cstdint on ubuntu-latest (ubuntu-26.04) - #139
Merged
Merged
Conversation
clean-clone has been red since ubuntu-latest moved to ubuntu-26.04: librocksdb-sys 0.16 (RocksDB 8.10) uses uint64_t in headers that never include <cstdint>, and that image's libstdc++ no longer pulls it in transitively, so every cold build fails with "'uint64_t' has not been declared". check-and-test and coverage pass only because rust-cache restores a built librocksdb-sys; the next cache miss fails them the same way. CXXFLAGS="-include cstdint" at workflow level in ci.yml and coverage.yml. release.yml and clients.yml pin ubuntu-24.04 and are unaffected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GFs5h16gS5ZBxRkjVKYqWY
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
dendisuhubdy
added a commit
that referenced
this pull request
Oct 27, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GFs5h2dLSM1W8hCpfnoNyc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clean-clonehas been red sinceubuntu-latestbecame ubuntu-26.04. librocksdb-sys 0.16 (RocksDB 8.10) usesuint64_tin headers that never include<cstdint>. That image's libstdc++ no longer pulls it in transitively, so every cold build fails with'uint64_t' has not been declared.check-and-testandcoveragepass only because rust-cache restores an already-built librocksdb-sys. The next cache miss will fail them the same way.Fix:
CXXFLAGS: -include cstdintat workflow level inci.ymlandcoverage.yml.release.ymlandclients.ymlpin ubuntu-24.04 and are unaffected.Not in this PR:
supply-chainis red on RUSTSEC-2026-0387 (crypto-bigint 0.5.5 via k256 0.13). That needs a decision on a k256 0.14 upgrade.🤖 Generated with Claude Code