Repository navigation
ci: run the clients' real-node suites against every fullnode change - #138
Merged
Merged
Conversation
.github/workflows/clients.yml, job `wallet-e2e`: builds rand-node and rand-prover from the commit under test, checks out randprotocol/clients (the same-named branch when there is one, so a deliberate RPC change lands as a pair that goes green together; else main), builds the wallet's wasm core from the clients' vendored fullnode and runs scripts/e2e-node.sh: the whole client-side RPC contract on a plain chain, the wallet flows and one real spend, and the same wallet on a chain with every genesis section it reads. Until now the clients tested only against a published release, so a change here that broke the wallet surfaced at the next release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
New workflow
.github/workflows/clients.yml, jobwallet-e2e: buildsrand-node+rand-proverfrom the commit under test, checks out randprotocol/clients (same-named branch if it exists, else main), builds the wallet's wasm core and runsscripts/e2e-node.sh:Before this, the clients tested only against a published release, so a node change that broke the wallet surfaced at the next release.
Pairs with randprotocol/clients
test/clients-downstream; this PR's run uses that branch. To make it a gate, markwallet-e2eas a required check once both are merged.🤖 Generated with Claude Code