Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2014 +/- ##
========================================
Coverage 96.70% 96.71%
========================================
Files 221 221
Lines 31626 31676 +50
Branches 4779 4786 +7
========================================
+ Hits 30584 30635 +51
Misses 1037 1037
+ Partials 5 4 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
louise-davies
left a comment
louise-davies
left a comment
There was a problem hiding this comment.
Mainly just need to account for version DOI landing pages as well :) and some minor style comments whilst I was requesting changes anyway
| label={t('breadcrumbs.investigation_other')} | ||
| value="investigation" | ||
| /> | ||
| {doitype !== 'User-defined-concept' && ( |
There was a problem hiding this comment.
This check is too narrow - if a user visits a version DOI landing page then they would see the investigation tab.
We can test for both user-defined types using !doiType.includes("User-defined")
| ); | ||
|
|
||
| const isSessionDOI = data?.type?.name === 'Investigation'; | ||
| const doitype = data?.type?.name; |
There was a problem hiding this comment.
We're accessing data?.type?.name twice here, instead if we move the doitype definition before isSessionDOI, we can refactor isSessionDOI to use doitype instead of re-accessing data?.type?.name
Also, doitype should probably be camelCase so doiType
2 participants
Description
Remove visits tab from user defined DOI landing page & remove datafiles tab from session DOI landing page
Testing instructions
Agile board tracking
closes #1996