Enhancement/disable contributer functionality#1993

[xkyue]

##Description
Disable the contributor functionality and changed relevant texts strings and tests

##Testing instructions

• Review code
• Check Actions build
• Review changes to test coverage

Agile board tracking

closes #1993

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.71%. Comparing base (94c656b) to head (777da9c).
⚠️ Report is 25 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2001      +/-   ##
===========================================
+ Coverage    96.70%   96.71%   +0.01%     
===========================================
  Files          221      221              
  Lines        31614    31689      +75     
  Branches      4779     4786       +7     
===========================================
+ Hits         30572    30648      +76     
+ Misses        1037     1036       -1     
  Partials         5        5              

Flag	Coverage Δ
common	95.52% <100.00%> (+<0.01%)	⬆️
dataview	98.42% <100.00%> (+0.01%)	⬆️
download	96.88% <100.00%> (+<0.01%)	⬆️
search	95.64% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[louise-davies]

Code works, just got some opinions on defaults/some code comments

[louise-davies]

2 comments:

The disableContributors option doesn't work at all on the edit page (in datagateway-dataview). I believe this is because you haven't modified the reducer in datagateway-dataview/src/state/reducers/dgdataview.reducer.tsx - you need a handleFeatureSwitches reducer that handles the datagateway-dataview specific feature switches aka disableContributors

Not specifying disableContributors in datagateway-download defaults to not showing the contributors button. If we're calling it disableContributors rather than enableContributors, then the feature should default to being visible when disableContributors is undefined