Repository navigation
Sessions: a window on an older session service says its typing protections are not active (#426) - #456
Merged
Conversation
…tions are not active (#426) An older NMSh's session service (v0.20.0's: the same protocol, so new windows attach to it and its live sessions keep running) still routes what is typed while a command runs the way that version did: #426's and #436's protections are not active in its sessions. The changelog said so; a window did not, beyond "fixes to how shells start are not in it". A window attached to a service without the look result those protections need now says, once: what you type while a command runs is routed as that version did, a password typed before a program asks can be shown, queued or run as a command, and the service restarts by itself once every NMSh window and live session has ended. Keyed on the capability, not the version string; a service from this release says nothing.
This was referenced Oct 19, 2026
Input ownership: a line queued during a command that is not a command waits for approval (#426)
#448
Merged
Merged
Composer: a block mixing NMSh and shell commands is reviewed, then offered one at a time (#450)
#451
Merged
Owner
Author
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the #426 review (older session-service compatibility).
The compatibility as the code provides it: the session protocol is unchanged (version 2), so a v0.20.0 session service keeps serving its live sessions and new v0.22 windows attach to it. Input routing while a command runs lives in that service, so #426's and #436's protections aren't active in its sessions until it restarts. It restarts by itself once every NMSh window and live session has ended. The changelog said so; the window didn't, beyond "fixes to how shells start are not in it yet".
Change: a window attached to a service without
input-look-result(the look result those protections are built on, new in this release) says so once, as a warning. It covers what can happen and when it ends. Keyed on the capability, not a version string; a service from this release says nothing. No guarantee is added beyond what the code does.Tests:
sessionService(fails before; the v0.20.0 feature set and this release's set). Session, compatibility and startup suites: 36/36. Typecheck clean.