Repository navigation
fix(brand): serve the R/ favicon reliably and fix the manifest link - #60
Merged
Merged
Conversation
- add icon.svg built from the Caveat R/ glyphs: sharp at every size and switches to a dark tile with the system color scheme; the new URL also makes browsers drop the cached old favicon - rebuild favicon.ico from the same artwork and declare the modern set (ico 32x32, svg, apple-touch-icon); drop the upscaled 16px shortcut - the manifest link pointed at a nonexistent site.webmanifest (404), so home-screen icons never loaded; link the real manifest.webmanifest and serve it as application/manifest+json - nginx no longer answers missing .css/.js/.jpg/.svg/.json files on the main site with index.html (soft 404); Storybook keeps its fallback - icons spec checks every icon and manifest link loads as an image or manifest, and that missing assets return 404 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
icon.svg: the R/ drawn from the Caveat glyph outlines (3 KB). It is sharp at any size and switches to a dark tile when the OS is in dark mode. Being a new URL, it also forces browsers to fetch the icon again.favicon.icois rebuilt from the same artwork as the legacy fallback. The upscaled 16px "shortcut" icon is removed.site.webmanifest, which doesn't exist, so Android and PWA home-screen icons never loaded. It now linksmanifest.webmanifest, and nginx serves it asapplication/manifest+json..css/.js/.jpg/.svg/.jsonfiles on the main site withindex.htmland a 200 status. That is why a missing/icon.svglooked fine on production. Those files now return 404; Storybook keeps its fallback. This changesnginx/, so the deploy will rebuild the nginx image.Verification
tests/icons.spec.ts: every icon, the apple-touch icon, the manifest and the icons it lists load with an image or manifest content type; missing assets return 404; the SVG carries its dark-mode styles./icon.svgserved as HTML).🤖 Generated with Claude Code