fix(governance): raise PR #596's ceilings for its codecov coverage-gap fix - #600
Conversation
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe PR size exception for PR ChangesPR size exception
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates the scoped size exception for the finalized test coverage changes. No current merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis test-only coverage fix adds targeted branch tests across six service modules and updates the narrowly scoped PR-size exception so PR #596 can remain within its governed file, commit, and meaningful-line limits; lint, prepush checks, and local exception matching were reported as passing. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Docker |  |
Sep 3, 2026 11:41p.m. | Review ↗ |
| Python | |
Sep 3, 2026 11:41p.m. | Review ↗ |
| Rust | |
Sep 3, 2026 11:41p.m. | Review ↗ |
| Shell | |
Sep 3, 2026 11:41p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
codeant-ai
Bot
added
the
size:XS
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR correctly updates the governance exception ceilings for PR #596 to accommodate test-only additions that close a codecov/patch coverage gap. The changes are properly scoped (5 new test files, 1 additional commit, 293 additional meaningful lines) and align with the stated purpose of addressing untested reset-in-progress-rejection, generation-mismatch, onversionchange, and onerror branches. The updated allowedPaths correctly includes all 5 new test files, and the comprehensive reason field documents the evolution from the previous 15-commit state through the coverage fix. No blocking defects found.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…p fix codecov/patch failed at 67.20% (target 74.99%) on #596's diff -- root-caused by downloading and inspecting the actual CI-generated lcov.info directly (not just the Codecov dashboard): the gap was real, not stale data, and traced to reset-in-progress-rejection/generation-mismatch/onversionchange/ onerror branches left untested across most of the reset-gate's service modules. Closed as a new 16th commit with 5 new test files, no production changes. A subsequent coderabbit finding on logSinks.test.ts (two reset-race tests synchronized via a fixed `await Promise.resolve()` -- coupled to the write queue's internal await-depth, silently degrading test 2's coverage of the generation-invalidation branch if that depth ever changed) was fixed in the same wave by waiting on observable evidence instead (beginIdbOpenAdmission()/indexedDB.open() spies). maxFiles: 65 -> 70, maxCommits: 15 -> 16, maxNonExemptMeaningfulLines: 1900 -> 2199, all exact measurements re-verified against current main, not carried forward from an earlier estimate.
64c5613 to
002f1ee
Compare
There was a problem hiding this comment.
No application code in the PR — skipped Code Health checks.
See analysis details in CodeScene
Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
1 participant
User description
Summary
PR #596's
codecov/patchcheck failed at 67.20% (target 74.99%). Root-caused by downloading and directly inspecting the actual CI-generatedlcov.infoartifact (not just the Codecov dashboard, which can lag or be misread) -- the gap was real, not stale data: Codecov correctly counts a line with only partial branch coverage as not-fully-covered, and this PR's own earlier review-fix commits had left the reset-in-progress-rejection, generation-mismatch,onversionchange, andonerrorbranches largely untested across most of the reset-gate's service modules.Closed with test-only additions (no production code changed):
services/storage/idbCore.tsservices/crossProjectIndexService.tsservices/diagnostics/logSinks.tsservices/proForge/proForgeHistoryStore.tsservices/proForge/proForgeMemoryBank.tspackages/worker-bus/src/deadLetterQueue.tsA subsequent CodeRabbit finding on
logSinks.test.tsflagged that two reset-race tests were synchronized via a fixedawait Promise.resolve()-- coupled to the write queue's internal await-depth, and would silently stop covering the intended generation-invalidation branch if that depth ever changed. Fixed in the same wave by waiting on observable evidence instead (beginIdbOpenAdmission()/indexedDB.open()spies), verified stable across 5 repeated runs.This PR updates
config/pr-size-exceptions.json'spr-596-532-e2e-startup-determinismentry:maxFiles(65 -> 70, 5 new test files),maxCommits(15 -> 16),maxNonExemptMeaningfulLines(1900 -> 2199, exact re-measurement against current main after the synchronization fix).Verification
Simulated the exception match locally against the rebased #596 branch:
Test plan
pnpm run lint-- cleanpnpm run ci:prepush-- all local checks PASSPR_SIZE_EXCEPTION=APPLIEDonce this mergesCodeAnt-AI Description
Raise the PR #596 size allowance to include coverage tests
What Changed
Impact
✅ Higher coverage for reset and storage failure paths✅ More reliable reset-race tests✅ PR size checks pass for the completed review fixes💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Summary by CodeRabbit