fix(governance): raise PR #596's ceilings for its second review-fix wave - #599
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
🤖 CodeAnt AI — Review Status
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reachedNext included review available in 13 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 70 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Comment |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates PR #596's size-exception entry to account for its 15th commit, 136 additional meaningful lines, and the replacement of a reverted settings-file path with the new IndexedDB regression tests; the PR description reports that lint, pre-push checks, and local exception matching all pass. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
codeant-ai
Bot
added
the
size:XS
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR correctly updates the PR size exception configuration for PR #596's second review wave. The changes are internally consistent: one file dropped from and one added to allowedPaths (maintaining the 65-file count), maxCommits incremented from 14 to 15, and maxNonExemptMeaningfulLines raised from 1741 to 1877. The verification output confirms the exception will apply as intended. No blocking issues identified.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Docker |  |
Sep 3, 2026 8:46p.m. | Review ↗ |
| Python | |
Sep 3, 2026 8:46p.m. | Review ↗ |
| Rust | |
Sep 3, 2026 8:46p.m. | Review ↗ |
| Shell | |
Sep 3, 2026 8:46p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
CodeAnt, CodeRabbit, and cubic independently surfaced a second wave of genuine reset-gate gaps (docPersistence.ts closer-unregister timing and swallowed destroy() failures, idbResetGate.ts late-closer and double-invocation races, idbCore.ts concurrent-open orphaning, factoryResetService.ts onblocked/onsuccess ordering, plus test-only fixes), fixed as a new 15th commit. FactoryResetDangerZone.tsx's dead data-testid removal reverted that file to byte-identical with main, so it drops from allowedPaths; tests/unit/storage/idbCore.test.ts is a new regression-test file added in its place. A same-review-cycle coderabbit follow-up then found the idbCore.ts fix also needed a live-handle guard (not just single-flight) so a live sibling database isn't reopened when only the other one needs a fresh open -- folded into the same 15th commit. maxCommits: 14 -> 15, maxNonExemptMeaningfulLines: 1741 -> 1900, both exact measurements.
9c914ca to
0da93aa
Compare
There was a problem hiding this comment.
No application code in the PR — skipped Code Health checks.
See analysis details in CodeScene
Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
1 participant
User description
Summary
PR #596's live review (CodeAnt, CodeRabbit, cubic — independently) surfaced a second wave of genuine, narrowly-scoped gaps in files already inside its exception scope:
services/localFirst/docPersistence.ts: the reset closer unregistered before its underlyingprovider.destroy()settled (couldn't be awaited by the barrier), and a rejecteddestroy()was silently swallowed before the reset gate ever saw it.services/storage/idbResetGate.ts: a closer registering after the drain loop already emptied (but beforeendIdbReset()) was never invoked at all; a closer that itself registers another closer mid-drain could be invoked twice via the liveSetiteration.services/storage/idbCore.ts: concurrentinitDB()callers before the first open resolved each started their ownindexedDB.open(), letting the lastonsuccesssilently orphan every earlier connection.services/factoryResetService.ts:deleteDatabase()rejected immediately ononblocked, releasing the reset gate while deletion was still asynchronously pending — now bounded by a timeout instead.services/sceneRevisionService.ts: missing the identity checkloraAdapterService.tsalready had.data-testidremoval, and several test-only wording/mock-leak fixes.These were fixed as a new 15th commit on #596 (a materially separate review round from the prior wave, not amended).
components/settings/FactoryResetDangerZone.tsx's dead-testid removal reverted that file to byte-identical withmain, so it drops out ofallowedPaths;tests/unit/storage/idbCore.test.tsis a new regression-test file added in its place.This PR updates
config/pr-size-exceptions.json'spr-596-532-e2e-startup-determinismentry:maxCommits(14 → 15),maxNonExemptMeaningfulLines(1741 → 1877), and swaps the oneallowedPathsentry. No other figures change.Verification
Simulated the exception match locally against the rebased #596 branch:
Test plan
pnpm run lint-- cleanpnpm run ci:prepush-- all local checks PASSPR_SIZE_EXCEPTION=APPLIEDonce this mergesSummary by Sourcery
Enhancements:
CodeAnt-AI Description
Update the PR size exception for the second review-fix wave
What Changed
Impact
✅ Accurate governance limits for PR #596✅ Regression coverage for concurrent IndexedDB opens✅ Approved file scope matches the current PR💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Summary by cubic
Updates PR #596's size-exception ceilings in
config/pr-size-exceptions.jsonto cover its second review-fix wave.docPersistence.ts,idbResetGate.ts,idbCore.ts,factoryResetService.ts, andsceneRevisionService.ts, plus test-only fixes; theidbCore.tsfix also gained a live-handle guard folded into the same 15th commit.FactoryResetDangerZone.tsxreverted to byte-identical with main and drops fromallowedPaths;tests/unit/storage/idbCore.test.tsjoins in its place.maxCommitsrises 14→15 andmaxNonExemptMeaningfulLinesrises 1741→1900;maxFilesstays 65.Written for commit 0da93aa. Summary will update on new commits.