Skip to content

fix(governance): retarget PR size exception from #583 to #596 - #597

Merged
qnbs merged 1 commit into
mainfrom
fix/pr-size-exception-583-to-596
Sep 3, 2026
Merged

fix(governance): retarget PR size exception from #583 to #596#597
qnbs merged 1 commit into
mainfrom
fix/pr-size-exception-583-to-596

Conversation

@qnbs

@qnbs qnbs commented Sep 3, 2026

Copy link
Copy Markdown
Owner

User description

Summary

Verification

Simulated the exception match locally via a synthetic base commit + GITHUB_EVENT_PATH payload matching #596's real base/head (resolveException() reads the registry via git show <base>:... and requires PR identity from the event payload, so a bare CLI run can't exercise this path):

PR_SIZE_EXCEPTION=APPLIED outcome=within target id=pr-596-532-e2e-startup-determinism pr=#596 scope=65/65 files
TOTAL_MEANINGFUL_LINES=1611 NON_EXEMPT_MEANINGFUL_LINES=1611/1611 commits=14/14
BASE_GOVERNED=YES IDENTITY_MATCH=YES PATH_SCOPE_MATCH=YES
EFFECTIVE_LIMITS=files<=65;nonExemptLines<=1611;commits<=14

Test plan

  • pnpm run lint -- clean
  • pnpm exec vitest run tests/unit/tooling/checkPrSize.test.ts -- 57/57 passed
  • pnpm run ci:prepush -- all local checks PASS (classification AMBIGUOUS, cloud validation required as normal)
  • Local exception-application simulation (above) -- confirms fix(e2e): eliminate WelcomePortal startup/navigation nondeterminism (#532) #596 will show PR_SIZE_EXCEPTION=APPLIED once this merges
  • Fresh CI on this PR itself

Summary by Sourcery

Bug Fixes:


CodeAnt-AI Description

Retarget the PR size exception from closed PR #583 to successor PR #596

What Changed

Impact

✅ PR #596 receives its intended size review allowance
✅ Prevents the exception from being rejected due to a stale PR number
✅ Preserves the existing governance limits

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.


Summary by cubic

Retargets the PR size exception for the E2E startup determinism work from #583 to #596. #583 can't be reopened because GitHub permanently blocks reopening a closed PR after its branch is force-pushed, so the exception entry's prNumber and id now point to the live #596, which was opened from the identical branch/commit. All other exception figures (65 files/1611 lines/14 commits, allowed paths, methodology) are unchanged.

Written for commit 0228855. Summary will update on new commits.

Review in cubic

PR #583 could not be reopened after its branch was force-pushed during
the size recompute -- GitHub permanently blocks reopening a closed PR
once its head branch has been force-pushed or recreated. PR #596 was
opened from the identical branch/commit as #583's successor; this
updates the pr-size-exceptions.json entry's prNumber (and id) to match
so check-pr-size.mjs's identity match applies to the live PR. No other
figures in the entry change.
@codeant-ai

codeant-ai Bot commented Sep 3, 2026

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 0228855 Sep 03, 2026 · 18:40 18:40

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @qnbs, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 11 hours and 9 minutes by commenting @sourcery-ai review. Upgrade to get a review now.

@codeant-ai

codeant-ai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
worldscript-studio Ready Ready Preview Sep 3, 2026 6:41pm UTC

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 71 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Essentials

Run ID: 68a18db4-e6d9-43a1-b3fb-164d272c8182

📥 Commits

Reviewing files that changed from the base of the PR and between 110371f and 0228855.

📒 Files selected for processing (1)
  • config/pr-size-exceptions.json

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the governance exception registry to recognize PR #596, the unchanged successor to force-push-blocked PR #583, allowing the existing 65-file/1611-line/14-commit exception to match and pass the PR Size Governance check.

File-Level Changes

Change Details Files
Retarget the PR-size exception to the successor pull request so identity-based matching applies. config/pr-size-exceptions.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@what-the-diff

what-the-diff Bot commented Sep 3, 2026

Copy link
Copy Markdown

PR Summary

  • Update in PR Exception Identifier
    The identifier of the PR exception has been updated from 583 to 596 in the exceptions' data record.

  • Modification of PR Exception Reason
    The reason provided for the PR exception has been adjusted to better reflect the changes introduced to address variability during startup or navigation in our end-to-end (E2E) testing.

  • Addition of Explanation for PR Changes
    We have elaborated on the changes made in PR fix(e2e): eliminate WelcomePortal startup/navigation nondeterminism (#532) #583, accentuating the modifications made in the architecture related to the reset operation of IndexedDB, our database for client-side storage.

  • Reconciliation with Overlapping PRs
    We carefully looked into and resolved conflicts with other subsequent PRs that were modifying the same files.

  • Bug Fix in PR Size Check Script
    There was a bug in our check-pr-size.mjs script, which evaluates if the size of a PR is within acceptable limits. This has now been fixed.

  • Updated Allowed Paths List
    The list of allowed paths has been revised to include all the current changes, making sure it covers modifications made including, but not limited to, adjustments in generated locale bundles.

  • Formatting Adjustments in sidebar.json files
    Trailing newlines in several sidebar.json files have been adjusted to comply with our agreed-on formatting standards.

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Sep 3, 2026
@deepsource-io

deepsource-io Bot commented Sep 3, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 110371f...0228855 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Docker Sep 3, 2026 6:40p.m. Review ↗
Python Sep 3, 2026 6:40p.m. Review ↗
Rust Sep 3, 2026 6:40p.m. Review ↗
Shell Sep 3, 2026 6:40p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@codeant-ai

codeant-ai Bot commented Sep 3, 2026

Copy link
Copy Markdown

🏁 CodeAnt Quality Gate Results

Commit: 0228855e
Scan Time: 2026-09-03 18:41:09 UTC

✅ Overall Status: PASSED

Quality Gate Details

Quality Gate Status Details
Secrets ✅ PASSED 0 secrets found
Duplicate Code ✅ PASSED 0.0% duplicated
SAST ✅ PASSED No security issues
Bugs ✅ PASSED Rating S: No bugs
IAC ✅ PASSED Rating S: No issues

View Full Results

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR correctly retargets the PR size exception from #583 to #596 following GitHub's permanent block on reopening #583 after a force-push. The changes are minimal and precise: updating the id field, prNumber field, and appending an identity note to the reason field. All technical details (maxFiles: 65, maxNonExemptMeaningfulLines: 1611, maxCommits: 14, allowedPaths, and headRef) remain unchanged, correctly reflecting that PR #596 contains identical content to #583. The configuration update is internally consistent and will allow the PR Size Governance check to correctly apply the exception to PR #596.

Approved for merge.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

@codescene-access codescene-access Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No application code in the PR — skipped Code Health checks.

See analysis details in CodeScene

Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

You’re at about 96% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

Re-trigger cubic

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@qnbs
qnbs merged commit ca85039 into main Sep 3, 2026
42 checks passed
@qnbs
qnbs deleted the fix/pr-size-exception-583-to-596 branch September 3, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant