fix: handle D-pad actions in input manager - #2877
Open
w3lld1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I updated
InputManagerto translate D-pad vector transitions into the corresponding configured action press and release events. The manager now tracks the previous D-pad state so unchanged directions do not emit duplicate actions, including when moving between cardinal and diagonal directions.I also added focused regression tests for presses, releases, direction changes, and unchanged input.
Validation
xvfb-run --auto-servernum uv run pytest -q tests/unit/test_input_manager.pyuv run pyright arcade/input/manager.pyuv run ruff format --check arcade/input/manager.py tests/unit/test_input_manager.pyuv run ruff check --ignore E501 arcade/input/manager.py tests/unit/test_input_manager.pygit diff --check origin/development...HEADI did not run the full test suite locally; GitHub Actions can cover the broader matrix.
Fixes #2871