gh-155051: Reject None keyword arguments in decimal.localcontext() - #155054
Open
serhiy-storchaka wants to merge 2 commits into
Open
gh-155051: Reject None keyword arguments in decimal.localcontext()#155054serhiy-storchaka wants to merge 2 commits into
serhiy-storchaka wants to merge 2 commits into
Conversation
None is not a valid value for any of the context attributes. The C implementation silently ignored it, because it shared the code with the Context constructor, where None means "not specified". The pure Python implementation always rejected it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
skirpichev
approved these changes
Aug 2, 2026
Comment on lines
+2061
to
+2068
| prec: object = NULL | ||
| rounding: object = NULL | ||
| Emin: object = NULL | ||
| Emax: object = NULL | ||
| capitals: object = NULL | ||
| clamp: object = NULL | ||
| flags: object = NULL | ||
| traps: object = NULL |
Member
There was a problem hiding this comment.
As in #155047, this is not rendered well by signature().
Member
Author
There was a problem hiding this comment.
We already use @text_signature "($module, /, ctx=None, **kwargs)" for this method. And the Python implementation has the same signature.
Member
There was a problem hiding this comment.
Yes, there is no regression. Though, I think in future we could use here explicit arguments with a sentinel.
# Conflicts: # Modules/_decimal/_decimal.c # Modules/_decimal/clinic/_decimal.c.h
serhiy-storchaka
enabled auto-merge (squash)
August 2, 2026 06:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None is not a valid value for any of the context attributes. The C implementation silently ignored it, because it shared the code with the
Contextconstructor, whereNonemeans "not specified". The pure Python implementation always rejected it.