[3.15] gh-110128: Ignore a truncated final row in csv.Sniffer - #155037
Open
Punisheroot wants to merge 1 commit into
Open
[3.15] gh-110128: Ignore a truncated final row in csv.Sniffer#155037Punisheroot wants to merge 1 commit into
Punisheroot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #110128.
When a sample is truncated in the middle of its final row, the incomplete row can distort the character-frequency table used by
_guess_delimiter()and causeSniffer.sniff()to raisecsv.Error.This change excludes the final physical row from delimiter detection when the sample contains multiple rows and does not end with
\ror\n. A single unterminated row remains usable.The handling is intentionally kept within the existing
_guess_delimiter()row preparation, making this a targeted maintenance-branch fix without changing the delimiter-detection algorithm. It mirrors thecut and len(rows) > 1behavior of the rewritten Sniffer in Python 3.16. If maintainers would prefer the truncation handling at a different level, I’m happy to adjust the implementation.Tests cover: