Skip to content

gh-155031: repass permission errors on subprocesses to parent / user #155032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flowln wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −2
Open

gh-155031: repass permission errors on subprocesses to parent / user #155032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c888bf0
fix(tachyon): repass permission errors on subprocesses to parent / user
flowln Aug 1, 2026
620339d
news: add NEWS entry for the fixed issue
flowln Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/profiling/sampling/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,13 @@ def handle_permission_error():
print(WINDOWS_PERMISSION_ERROR, file=sys.stderr)
else:
print(GENERIC_PERMISSION_ERROR, file=sys.stderr)
sys.exit(1)

if __name__ == '__main__':
try:
main()
except PermissionError:
handle_permission_error()
sys.exit(1)

@picnixz picnixz Aug 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand this. sys.exit() is already called within the handler.

@flowln flowln Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to commit removing the sys.exit call from there, my bad. Seems less confusing to have all code in the except paths ending with sys.exit than to call it from the helper function

except SamplingUnknownProcessError as err:
print(f"Tachyon cannot find the process: {err}", file=sys.stderr)
sys.exit(1)
Expand Down
1 change: 0 additions & 1 deletion Lib/profiling/sampling/_child_monitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,6 @@ def _spawn_profiler_for_child(self, child_pid):
cmd,
stdin=subprocess.DEVNULL,
stdout=subprocess.DEVNULL,
stderr=subprocess.DEVNULL,
)
with self._lock:
if self._stop_event.is_set():
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2026-08-01-10-54-39.gh-issue-155031.sTB_n8.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Propagate to user any permission errors from subprocess attach commands in
Tachyon
Loading