gh-151138: Correct documented tempfile Windows temp directory search order - #155029
Draft
Diwak4r wants to merge 1 commit into
Draft
gh-151138: Correct documented tempfile Windows temp directory search order#155029Diwak4r wants to merge 1 commit into
tempfile Windows temp directory search order#155029Diwak4r wants to merge 1 commit into
Conversation
The existing docs claim gettempdir() searches C:\TEMP, C:\TMP, \TEMP, \TMP on Windows, but the actual implementation (Lib/tempfile.py lines 192-194) first checks TMPDIR, TEMP, and TMP environment variables. On Windows, TEMP and TMP typically point to: - %USERPROFILE%\AppData\Local\Temp (user temp) - %SYSTEMROOT%\Temp (system temp) Update the docs to reflect the actual search order: env vars first, then hardcoded fallback paths. Fixes python#151138
|
The following commit authors need to sign the Contributor License Agreement: |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Documentation build overview
|
tempfile Windows temp directory search order
StanFromIreland
marked this pull request as draft
August 1, 2026 18:23
Member
|
You'll have to sign the CLA before we can review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
tempfile.gettempdir()docs incorrectly document the Windows temp directory search order.Current docs claim:
Actual implementation (
Lib/tempfile.pylines 192-194):On Windows,
TEMPandTMPenv vars point to%USERPROFILE%\AppData\Local\Temp(user temp) and%SYSTEMROOT%\Temp(system temp), not the hardcoded paths the docs claim.Fixes #151138.
Fix
Update
Doc/library/tempfile.rstto document the correct search order:This reflects actual runtime behavior: environment variables first, then hardcoded fallback paths.
Test
Documentation-only change. Verified docs build with
make html.