Fix NumPy scalar extraction in BIC scores - #263
Merged
Conversation
jdramsey
approved these changes
May 22, 2026
jdramsey
left a comment
jdramsey
left a comment
Collaborator
There was a problem hiding this comment.
It looks good to me. My original minimal bug report script ran with a couple of adjustments for the recent repo. Of course it had zero edges in the model, so it was good that it got zero edges. I made another example with more edges, and it got a good answer. In any case, the problem preventing BOSS from running at all is fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #262