Skip to content

Unchanged coverage treated as a Coverage evolution decrease聽#756

Description

@jgravois

greetings and thank you for maintaining this awesome github action! 馃憢

i've noticed some counter-intuitive behavior in my own project. is it by design that only an increase in coverage results in a green 'Coverage evolution' badge?

live example: cal-itp/benefits#4103 (comment)
Image

perhaps its just a quirk/misconfiguration on my end? I would expect to see: 馃煝 Coverage evolution: 94% = 94% 馃煝

Activity

  1. ewjoachim commented on Sep 24, 2026

    @ewjoachim
    Member

    I would expect to see: 馃煝 Coverage evolution: 94% = 94% 馃煝

    the > doesn't stand for greater but for went from x to y. I've replaced it with an arrow (in addition to solving the floating point bug)(... I think :D)

  2. jgravois commented on Sep 24, 2026

    @jgravois
    Author

    the > doesn't stand for greater

    ah. in this case i agree that an arrow is an improvement!

    (in addition to solving the floating point bug)(... I think :D)

    rock n roll! 馃幐 i'll update and let you know if i see anything unexpected.

    thanks for engaging!

    edit: looks great to me! cal-itp/benefits#4113

  3. thekaveman commented on Sep 24, 2026

    @thekaveman

    @ewjoachim thank you so much for the quick fix here!

  4. ewjoachim commented on Sep 25, 2026

    @ewjoachim
    Member

    You're welcome. Thanks for raising this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions