Repository navigation
feat(mobile): give privacy controls their own page under Account - #334
Conversation
Account now shows one Privacy controls row with the current state
("Diagnostics on · Product analytics off"). It opens a page with Strictly
necessary (Always on), Diagnostics and Product analytics, a group footer,
and Privacy policy and Services we use links. Copy is the legal-approved
set from putdotio/support#135.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JgjQBuocfA1x8TCrkYDjRJ
Generated by Claude Code |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f006ac0e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| }, | ||
| onRetryChange = { onSettingsEvent(AccountSettingsEvent.RetryChange) }, | ||
| onPrivacyControls = onPrivacyControls, |
There was a problem hiding this comment.
On a fresh launch where account settings remain loading or fail (for example, due to a network or access error), this callback is only wired through the AccountSettingsContent.Ready branch, so the Account screen never renders the Privacy controls row. Although the new privacy screen explicitly supports loading/failure states and keeps its policy links available, users cannot navigate to it in those states; expose the navigation row outside the ready-only settings items, using a fallback summary until preferences are available.
Useful? React with 👍 / 👎.
Requested by Altay · project thread
Change
Privacy controls move to their own page under Account, with the legal-approved copy from putdotio/support#135.
Validation
./gradlew verifyand./gradlew :mobile:assembleProductionDebug :tv:assembleProductionDebugUnverified: flipping either toggle on a live account.
https://claude.ai/code/session_01SyqPcpubVvq2EUofWGe9DW
Generated by Claude Code