Repository navigation
CS2 spec and data dictionary: player_status.is_spotted is gone - #75
Merged
Merged
Conversation
It was unreliable and the converter stops writing it. The CS2 changelog gets its entry when the converter change reaches production. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
All reviewed changes are consistent and no unresolved issues were identified.
No open issues 🎉
What changed in this PR
Updates the current CS2 documentation to remove the obsolete player_status.is_spotted field while preserving historical specifications.
Changes:
- Removes the field from the current CS2 specification.
- Removes the field from the CS2 data dictionary.
- Documents the change in
CHANGELOG.md.
| File | Description |
|---|---|
docs/datascience/adx/cs2/csds/spec.md |
Removes the field from the current schema. |
docs/datascience/adx/cs2/csds/assets/csds_dictionary.csv |
Removes the corresponding dictionary entry. |
CHANGELOG.md |
Records the schema change. |
Review effort: Lite
Member
Author
|
Copilot recommended approval with no points. Nothing to answer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CS2 spec and data dictionary drop
player_status.is_spotted. It was unreliable, and csgo-ppp stops writing it.docs/datascience/adx/cs2/csds/spec.md: the row goes.docs/datascience/adx/cs2/csds/assets/csds_dictionary.csv: the row goes.old/cs2,old/csgo) stay: they describe older data, which still has the column.npm run buildpasses.Order
Not before csgo-ppp's change is in production, so the published spec doesn't drop a column that new matches still carry. The production lock: igl-plant#119.
Related: csgo-coach#267, csgo-ppp#221, csgo-rushb#136
🤖 Generated with Claude Code