A layer that carries only a composition is not an empty layer - #171
Merged
Merged
Conversation
Found by bootstrapping the realm varve's own roadmap describes. `covalent` carries NO payloads of its own and only includes (REQ-COVALENT-001 clause 1): a pin names exactly one layer, so composing is the only way one pin reaches two toolchains, and a composition that also shipped binaries would be a fourth place tools are defined. Its manifest parsed. `plan` said "0 payload(s) from 0 release(s), realm 'covalent'". And `deposit` refused: "an empty layer is not a toolchain" — a guard that is right about emptiness and wrong about composition, which made that realm unbuildable while the manifest, the planner and the documentation all described it. Empty now means empty: no payloads AND nothing composed. The error says so, so the next person does not have to rediscover which of the two it meant. Controls: reverting to the payload-only check refuses a composition again; removing the guard lets a layer with neither payloads nor includes through. Both fail the test. Gate: fmt, clippy -D warnings, 1003 workspace tests, trace-gate, rivet validate. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019TNtfRjLNhEz82G2ggeeNu
avrabe
enabled auto-merge (squash)
September 18, 2026 18:40
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by bootstrapping the realm varve's own roadmap describes.
covalentcarries no payloads of its own and only includes (REQ-COVALENT-001 clause 1): a pin names exactly one layer, so composing is the only way one pin reaches two toolchains, and a composition that also shipped binaries would be a fourth place tools are defined.Its manifest parsed.
planreported0 payload(s) from 0 release(s), realm 'covalent'. Anddepositrefused:A guard that is right about emptiness and wrong about composition — so the realm was unbuildable while the manifest, the planner and the docs all described it.
The fix
Empty means no payloads and nothing composed. The error message now says which of the two it meant, and that a composition is accepted, so the next person does not rediscover this from a refusal.
Controls
Both fail the new test. Gate: fmt, clippy
-D warnings, 1003 workspace tests, trace-gate, rivet validate.This joins v0.37.0, which is being cut for this same line of work:
[[include]]in a manifest (#169) and a realm's stated opt-in reason reaching the deposit (#170, merged).🤖 Generated with Claude Code
https://claude.ai/code/session_019TNtfRjLNhEz82G2ggeeNu